Fix NH-3252 #204
Fix NH-3252 #204
Conversation
Handle ANSI strings in the same way that normal strings are handled.
|
@darrenkopp, can you please add unit tests? |
|
@hazzik Yes, I will add some tests for this. Saw this a week ago and haven't had time to do it, so just dropping this comment to let you know that I am aware and will add it when I get some time. |
|
@hazzik ok, added tests, and found new problems with by code mapping in the process XD. Everything here works though |
|
@darrenkopp what about fixing the issue you've found with mapping by code? (or at least please create a JIRA issue) |
|
Yeah... at the time didn't have time to do it, so never created a test covering it nor do i remember exactly what the issue was. I'll re-create a test for this using the by-code mapping method and I'll likely re-remember what the issue is and add a new jira ticket. It was either ignoring the length I was giving it, or it was not allowing ansistring, but I'm not sure exactly which one. |
|
Merged @ bea9bc9 Thanks, @darrenkopp |
This is similar to the fix proposed on jira for NH-3252. Basically size is handled the same way as string. Without this, can't do varchar(max), only nvarchar(max).